Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix valueChanged signals on PropertyWidget #352

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

tlambert03
Copy link
Member

wasn't getting emitted properly

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.60%. Comparing base (013635e) to head (091103e).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_widgets/_property_widget.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   90.59%   90.60%           
=======================================
  Files          74       74           
  Lines        8393     8396    +3     
=======================================
+ Hits         7604     7607    +3     
  Misses        789      789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 95117e7 into pymmcore-plus:main Jul 21, 2024
19 of 20 checks passed
@tlambert03 tlambert03 deleted the fix-propwdg-sig branch July 21, 2024 20:28
@tlambert03 tlambert03 added the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant