fix: Only allow YAML save/load when YAML available #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids exceptions arising from the attempt to save/load MDA settings from YAML files, when pyyaml is not installed.
Notably, I made the decision to prevent the selection of a YAML file within the
QFileDialog
. We could have alternatively shown it, but prevented the exception (through atry
/except
or other means) instead. I prefer this method as it leaves no room for unexpected behavior (namely a user trying to save into a YAML file and then save not being completed).Closes #333