Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: unfill radio buttions in GridPlanWidget #344

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

gselzer
Copy link
Contributor

@gselzer gselzer commented Jul 18, 2024

This PR, closing #339, adds a HACK to prevent the OS accent color from filling up the GridPlanWidget's radio buttons on Windows 11. This HACK seems to be the least-bad of the different options that could resolve the issue, which are:

  • Setting the style sheet, as I did here, to override the accent color fill
  • Adding the radio buttons to the layout of the QScrollArea itself, which is worse as it alters the hierarchy of the widget.

@tlambert03 and/or @fdrgsp: I'd be happy for your opinions and/or testing. It looks nice to me on Windows 11, and on WSL (Wayland)

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.59%. Comparing base (7ec66e5) to head (5b481c6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files          74       74           
  Lines        8379     8380    +1     
=======================================
+ Hits         7591     7592    +1     
  Misses        788      788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gselzer
Copy link
Contributor Author

gselzer commented Jul 18, 2024

Closes #339

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hilarious 😂 ... works for me! looks exactly the same as before on macos

@tlambert03 tlambert03 merged commit 8e52e0f into pymmcore-plus:main Jul 18, 2024
20 checks passed
@gselzer gselzer deleted the fix-radio-style branch July 18, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants