Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: new widget to manage Groups and Presets #338

Closed
wants to merge 22 commits into from

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Jul 16, 2024

@tlambert03 I started from your nicel #307 PR and I've use the logic to create a new GroupPresetWidget. I believe it is easier to manage the Micro-Manager Groups and Presets (when compared to our current widget). I'm sure we can improve this but I think it is a good starting point.

Screen.Recording.2024-07-16.at.5.08.10.PM.mov

TODO:

  • add test

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 20.40441% with 433 lines in your changes missing coverage. Please review.

Project coverage is 86.76%. Comparing base (ae4a3dd) to head (fe5919a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...idgets/group_preset_widget/_group_preset_dialog.py 12.21% 273 Missing ⚠️
..._widgets/group_preset_widget/_properties_tables.py 21.30% 133 Missing ⚠️
...idgets/device_properties/_device_property_table.py 50.90% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   90.72%   86.76%   -3.96%     
==========================================
  Files          85       88       +3     
  Lines        9184     9712     +528     
==========================================
+ Hits         8332     8427      +95     
- Misses        852     1285     +433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdrgsp fdrgsp changed the title Configs [WIP] feat: new widget to manage Groups and Presets Jul 16, 2024
@tlambert03
Copy link
Member

I'm going to close this since i think #307 will encompass all the use cases here

@tlambert03 tlambert03 closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants