Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make name editable EditGroupWidget #328

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Jul 13, 2024

This PR makes the group name editable when interacting with the edit group dialog in the GroupPresetTableWidget.

closes #324

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.59%. Comparing base (581906e) to head (9458465).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   90.58%   90.59%           
=======================================
  Files          74       74           
  Lines        8371     8375    +4     
=======================================
+ Hits         7583     7587    +4     
  Misses        788      788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title fix: make the group name editable fix: make name editable EditGroupWidget Jul 13, 2024
@tlambert03 tlambert03 merged commit 5957860 into pymmcore-plus:main Jul 13, 2024
19 of 20 checks passed
@fdrgsp fdrgsp deleted the fix-edit-group branch July 23, 2024 19:14
@tlambert03 tlambert03 added the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Config Groups to be Renamed
2 participants