Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2D config preset table #320

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jul 12, 2024

proof of principle of the 2D table that @marktsuchida was describing in #307 (comment)

Screenshot 2024-07-12 at 8 45 40 AM

would still need:

  • ability to add a new row (a new dev/prop that all presets should set)
  • ability to add/remove columns (to add/remove presets)
  • editable column headers (to rename a preset)
  • deal with jagged config groups (where not all presets have the same dev/props)

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 177 lines in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (1cda2b7) to head (92fb2f8).

Files with missing lines Patch % Lines
src/pymmcore_widgets/_config_preset_table.py 0.00% 177 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   90.71%   89.01%   -1.71%     
==========================================
  Files          85       86       +1     
  Lines        9234     9411     +177     
==========================================
  Hits         8377     8377              
- Misses        857     1034     +177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant