Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the CameraRoiWidget to handle multiple cameras #292

Merged
merged 22 commits into from
Nov 22, 2024

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Apr 24, 2024

Screenshot 2024-04-24 at 2 40 29 PM

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 93.26599% with 20 lines in your changes missing coverage. Please review.

Project coverage is 89.80%. Comparing base (33c1350) to head (e62387c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_widgets/control/_camera_roi_widget.py 93.26% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   90.73%   89.80%   -0.94%     
==========================================
  Files          85       85              
  Lines        9233     9377     +144     
==========================================
+ Hits         8378     8421      +43     
- Misses        855      956     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fdrgsp fdrgsp changed the title [WIP] feat: update the CameraRoiWidget to handle multiple cameras feat: update the CameraRoiWidget to handle multiple cameras May 22, 2024
@tlambert03
Copy link
Member

hey @fdrgsp, is this still something we should get in? I haven't looked closely yet, but I'm wondering why support for two cameras would require a diff of 700+ lines. was this harder than it sounds?

@fdrgsp
Copy link
Collaborator Author

fdrgsp commented Oct 4, 2024

Hey @tlambert03 , I had to change the logic a bit to support the Multi Camera adapter so that each camera could be controlled individually. I also added a CameraInfo dataclass to store the info of each camera. I did it a while ago so I probably need to dig more into the code to exactly remember why the changes!

@tlambert03 tlambert03 merged commit 7f37c83 into pymmcore-plus:main Nov 22, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants