Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: small fix to test #311

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

tlambert03
Copy link
Member

this fixes a small issue in one of the tests. Not sure why it hasn't been failing on ci:

the MDASequence.replace() method will serialize all objects, including metadata... meaning it may turn a SequenceMeta() object into a dict... that's a broader issue that needs examining, but this is just a local workaround

@tlambert03 tlambert03 changed the title tests: small fix to test test: small fix to test Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c33cb23) 78.24% compared to head (2f054fe) 78.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files          15       15           
  Lines         671      671           
=======================================
  Hits          525      525           
  Misses        146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit c43442a into pymmcore-plus:main Feb 2, 2024
17 of 18 checks passed
@tlambert03 tlambert03 deleted the fix-test branch February 2, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant