Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error when loading SequenceMeta as dict #310

Merged
merged 4 commits into from
Feb 2, 2024
Merged

fix: fix error when loading SequenceMeta as dict #310

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13028d8
test: add test for SequenceMeta fix
fdrgsp Feb 2, 2024
12ce21d
fix: fix MDA setValue
fdrgsp Feb 2, 2024
402e327
Merge branch 'main' into fix_meta_error
tlambert03 Feb 2, 2024
8b203b4
simplify
tlambert03 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/napari_micromanager/_gui_objects/_mda_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@
def setValue(self, value: MDASequence) -> None:
"""Set the current value of the widget."""
if nmm_meta := value.metadata.get(SEQUENCE_META_KEY):
if isinstance(nmm_meta, dict):
tlambert03 marked this conversation as resolved.
Show resolved Hide resolved
nmm_meta = SequenceMeta(**nmm_meta)

Check warning on line 60 in src/napari_micromanager/_gui_objects/_mda_widget.py

View check run for this annotation

Codecov / codecov/patch

src/napari_micromanager/_gui_objects/_mda_widget.py#L60 

Added line #L60 was not covered by tests
if not isinstance(nmm_meta, SequenceMeta): # pragma: no cover
raise TypeError(f"Expected {SequenceMeta}, got {type(nmm_meta)}")

Expand Down
Loading