Update notebook GLM-negative-binomial-regression to pymc v5 #573 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
drbenvincent
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Hi @wesleyboelrijk. Thanks for the contribution! Looks great, but I just left a few minor change requests.
examples/generalized_linear_models/GLM-negative-binomial-regression.ipynb
Outdated
Show resolved
Hide resolved
OriolAbril
reviewed
Sep 28, 2023
examples/generalized_linear_models/GLM-negative-binomial-regression.myst.md
Outdated
Show resolved
Hide resolved
…ok based on PR feedback
Thanks @drbenvincent and @OriolAbril for the feedback! I made the requested changes. Let me know if any other changes are required :) |
OriolAbril
requested changes
Oct 2, 2023
3 tasks
OriolAbril
approved these changes
Nov 23, 2023
OriolAbril
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
#573
The notebook GLM-negative-binomial-regression was still using PyMC v4. I have updated it to PyMC v5.
Besides that, there is a dependency on seaborn, which was not listed in requirements-docs.txt. I have added this.
Lastly, seaborn gave a bunch of FutureWarnings upon plotting in the notebook. I added a warning suppression for those FutureWarnings.
Helpful links
📚 Documentation preview 📚: https://pymc-examples--575.org.readthedocs.build/en/575/