Migrate to pyproject.toml, update for numpy 2.0 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoubelet
added
Type: Feature
|
This requires a release after merge, to have a numpy 2 compatible version out there. I have updated version and changelog. |
|
Code Climate has analyzed commit 3383c1e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 68.4% (0.0% change). View more on Code Climate. |
JoschD
reviewed
Aug 13, 2024
JoschD
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next in the wave of PRs transitioning our packages to using the standard
pyproject.tomlfile.Important
The
setup.py,setup.cfgandMANIFEST.infiles are gone. Apyproject.tomlfile now centralises everything, including metadata conformly to PEP621.I have put down
hatchlingas a build backend, as it is the one developped byPyPA, the Python Packaging Authority, as they publish the authoritative user guide. This has little impact though, as any PEP518-compliant backend would work there instead.Simple change to have
numpy 2.0compatibility.Like for all other packages, this moves the minimum supported Python version to
3.9.Details
I have put Hatch as a packaging tool as it is also the one from PyPA, but it is strictly optional. One does not need Hatch, because standards. The new common workflows (PR upcoming) don't even use it.
I have taken upon me to up minimum required versions (
tfs-pandasfor instance).