Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uri detection #37

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix uri detection #37

merged 1 commit into from
Nov 30, 2023

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Nov 30, 2023

No description provided.

@JoschD JoschD added the Type: Bug Something isn't working as it should. label Nov 30, 2023
@JoschD JoschD requested a review from anabramo November 30, 2023 15:48
@JoschD JoschD self-assigned this Nov 30, 2023
Copy link

codeclimate bot commented Nov 30, 2023

Code Climate has analyzed commit fcd16eb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.4% (0.0% change).

View more on Code Climate.

Copy link

@anabramo anabramo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this should now catch more corner cases of bad eos paths.

@JoschD JoschD merged commit 2be7eeb into master Nov 30, 2023
21 checks passed
@JoschD JoschD deleted the fix_uri_detection branch November 30, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants