Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert_excel_date, convert_matlab_date for Polars #1365

Merged
merged 110 commits into from
Jul 3, 2024

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented May 21, 2024

PR Description

Please describe the changes proposed in the pull request:

  • Add convert_excel_date, convert_matlab_date for polars
  • deprecate convert_unix_date
  • update convert_excel_date and convert_matlab_date source code for pandas (vectorized pandas operations)
  • avoid dataframe mutation in pandas

This PR relates to #1352 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! Just need resolution of merge conflicts and we can merge!

@samukweku
Copy link
Collaborator Author

@ericmjl I made some changes to #1363 ... open to feedback on a better way

@ericmjl
Copy link
Member

ericmjl commented Jun 21, 2024

@samukweku looks like we have some conflicts to resolve on this branch, and then we can merge!

@ericmjl ericmjl merged commit e74f323 into dev Jul 3, 2024
4 checks passed
@ericmjl ericmjl deleted the samukweku/convert_excel_date_polars branch July 3, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants