-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polars support for xlsx_table
#1357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://deploy-preview-1357--pyjanitor.netlify.app |
ericmjl
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I just remembered that we do doctests! As such, I don't think we need to extend test_readcommandline()
.
samukweku
added a commit
that referenced
this pull request
Jun 3, 2024
* add make_clean_names function that can be applied to polars * add examples for make_clean_names * changelog * limit import location for polars * limit import location for polars * fix polars in environment-dev.yml * install polars in doctest * limit polars imports - user should have polars already installed * use subprocess.run * add subprocess.devnull to docstrings * add subprocess.devnull to docstrings * add subprocess.devnull to docstrings * add subprocess.devnull to docstrings * add os.devnull * add polars as requirement for docs * add polars to tests requirements * delete irrelevant folder * changelog * create submodule for polars * fix doctests * fix tests; add polars to documentation * fix tests; add polars to documentation * import janitor.polars * control docs output for polars submodule * exclude functions in docs rendering * exclude functions in docs rendering * show_submodules=true * fix docstring rendering for polars * Expression -> expression * rename functions.py * pivot_longer implemented for polars * changelog * keep changes related only to pivot_longer * pd -> pl * pd -> pl * df.pivot_longer -> df.janitor.pivot_longer * df.pivot_longer -> df.janitor.pivot_longer * pd -> pl * pd -> pl * add >>> df * add >>> df * keep changes related only to polars pivot_longer * add polars support to read_commandline * remove irrelevant files * minor edit to docs * xlsx_table now supports polars --------- Co-authored-by: samuel.oranyeli <[email protected]> Co-authored-by: Eric Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
xlsx_table
now supports polarsThis PR relates to #1352
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.