Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polars support for xlsx_table #1357

Merged
merged 53 commits into from
Jun 3, 2024
Merged

polars support for xlsx_table #1357

merged 53 commits into from
Jun 3, 2024

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented May 1, 2024

PR Description

Please describe the changes proposed in the pull request:

  • xlsx_table now supports polars
jn.xlsx_table('../Downloads/016-MSPTDA-Excel.xlsx', table='dCategory',engine='polars')
Out[31]: 
shape: (5, 2)
┌────────────┬───────────────┐
│ CategoryIDCategory      │
│ ------           │
│ i64str           │
╞════════════╪═══════════════╡
│ 1Beginner      │
│ 2Advanced      │
│ 3Freestyle     │
│ 4Competition   │
│ 5Long Distance │
└────────────┴───────────────┘

This PR relates to #1352

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl
Copy link
Member

ericmjl commented May 1, 2024

@samukweku samukweku self-assigned this May 1, 2024
Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I just remembered that we do doctests! As such, I don't think we need to extend test_readcommandline().

@ericmjl ericmjl merged commit 46ab4d8 into dev Jun 3, 2024
4 checks passed
@ericmjl ericmjl deleted the samukweku/polars_xlsx_tables branch June 3, 2024 00:16
samukweku added a commit that referenced this pull request Jun 3, 2024
* add make_clean_names function that can be applied to polars

* add examples for make_clean_names

* changelog

* limit import location for polars

* limit import location for polars

* fix polars in environment-dev.yml

* install polars in doctest

* limit polars imports - user should have polars already installed

* use subprocess.run

* add subprocess.devnull to docstrings

* add subprocess.devnull to docstrings

* add subprocess.devnull to docstrings

* add subprocess.devnull to docstrings

* add os.devnull

* add polars as requirement for docs

* add polars to tests requirements

* delete irrelevant folder

* changelog

* create submodule for polars

* fix doctests

* fix tests; add polars to documentation

* fix tests; add polars to documentation

* import janitor.polars

* control docs output for polars submodule

* exclude functions in docs rendering

* exclude functions in docs rendering

* show_submodules=true

* fix docstring rendering for polars

* Expression -> expression

* rename functions.py

* pivot_longer implemented for polars

* changelog

* keep changes related only to pivot_longer

* pd -> pl

* pd -> pl

* df.pivot_longer -> df.janitor.pivot_longer

* df.pivot_longer -> df.janitor.pivot_longer

* pd -> pl

* pd -> pl

* add >>> df

* add >>> df

* keep changes related only to polars pivot_longer

* add polars support to read_commandline

* remove irrelevant files

* minor edit to docs

* xlsx_table now supports polars

---------

Co-authored-by: samuel.oranyeli <[email protected]>
Co-authored-by: Eric Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants