-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read_commandline
supports polars engine
#1356
Conversation
🚀 Deployed on https://deploy-preview-1356--pyjanitor.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I am going to see if I can push up a test for read_commandline()
.
This commit modifies the test_read_commandline function in the io module to accept an additional parameter, "engine". This allows the function to be tested with different engines, specifically "pandas" and "polars". The function calls within the test have been updated to pass this new parameter. The change is intended to improve the comprehensiveness of the test coverage.
This commit removes the default value for the 'engine' parameter in the test_read_commandline function. This change ensures that the function's behavior is explicitly defined by the test parameters.
@samukweku we're close with this one -- I think the line that is failing in assert df.equals(dataframe) Would you be kind enough to take a look at this particular error? I am quite sure it's got to do with the polars internal API, but that's one I'm not familiar enough with to know. |
…ne parameter - Removed the `engine` parameter from `test_read_commandline` function to simplify test logic. - Updated calls to `janitor.io.read_commandline` within the test to not pass the `engine` argument, aligning with the function's updated signature. This change does not affect the external API, hence no breaking change is introduced.
Also LGTM, thanks @samukweku! |
PR Description
Please describe the changes proposed in the pull request:
read_commandline
now supports polars**This PR relates to #1352 **
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.