-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INF] update some mkdocs infrastructure #1231
Conversation
`environment-dev.yml` is too bloated, for one: most formatting/linting tools should be controlled by `pre-commit` (which sets up its own isolated environments for each tool). Two exceptions: - `black`: since the vscode container uses the black binary to format on save - `isort`: this isn't in pre-commit config yet, to be fixed in the future
We are now using v0.9 mkdocs-material and mkdocs v1.4, along with it comes several compatibility changes. https://squidfunk.github.io/mkdocs-material/upgrade/ for CHANGELOG E.g. the `watch` option is recommended to use the global mkdocs one. `pymdownx` navigation extension names were wrong...
🚀 Deployed on https://deploy-preview-1231--pyjanitor.netlify.app |
Codecov Report
@@ Coverage Diff @@
## dev #1231 +/- ##
==========================================
+ Coverage 97.71% 97.77% +0.05%
==========================================
Files 78 78
Lines 3767 3767
==========================================
+ Hits 3681 3683 +2
+ Misses 86 84 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any ideas on the mkdocs-legacy? ok to remove and just have the new mkdocs?
Yea, I was thinking about this recently as well, since So I'm imagining that we'll need to:
Correction: hmm nvm, ignore me. It might be possible to just do an upgrade first (while still using the legacy parser), I'll investigate and report back. |
We can remove the pin on mkdocstrings to use v0.19+ (not quite, need an upstream bug to be fixed first), but I wouldn't make the jump to drop the "mkdocstrings-python-legacy" handler just yet. I rather we move to Google style along (#1032) with the upgrade to the new "mkdocstrings-python" handler together as a whole. I'll create a separate PR to upgrade our |
Just realized there's been multiple related PRs to this current one (some overlap), #1133, #1147 . I'll like your opinion on the changes I'm making, if possible @ericmjl @Zeroto521 🙏🏽 |
@thatlittleboy thank you for handling this PR! I've reviewed the changes and I'm good to go as well. Regarding docstring style, I'm also happy to make a move to Google-style docstrings now that AI coding tools are more generally available, as they can help with the migration. I have paid for Tabnine, but we can also edit ChatGPT's output. Without them, reformatting would be a chore. |
PR Description
Couple of minor infrastructure changes:
environment-dev.yml
to reduce the bloat (esp for our CIs), and to promote the use ofpre-commit
(which sets up its own isolated environments for each tool). Two exceptions:black
: since the vscode container uses the black binary to format on saveisort
: this isn't in pre-commit config yet, to be fixed in the futuremkdocs
and friends, there're some new compatibility changes with v0.9 mkdocs-material and mkdocs v1.4. E.g. thewatch
option is recommended to use the global mkdocs one.pymdownx
navigation extension names were wrong... etc.Development Guide
section to belowAPI reference
, since the latter is most likely what our users want to see (first).PR Checklist
Please ensure that you have done the following:
CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Relevant Reviewers
Please tag maintainers to review.