Fix order argument for quat_to_euler, quat_from_euler & mat_from_eulet #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korijn
changed the title
Korijn
changed the title
Korijn
commented
Dec 29, 2024
| elif out is None: | ||
| out = affine_matrix | ||
| else: | ||
| out @= affine_matrix |
There was a problem hiding this comment.
Probably just echoing into the void here but this was the first time in my life I used this operator. For some reason it feels special. :)
almarklein
reviewed
Dec 30, 2024
Comment on lines
+130
to
+132
| The rotation order as a string. Can include 'X', 'Y', 'Z' for intrinsic | ||
| rotation (uppercase) or 'x', 'y', 'z' for extrinsic rotation (lowercase). | ||
| Default is "xyz". |
There was a problem hiding this comment.
Out of curiosity, can a user also pass (or think he can pass) a mix of lowercase and uppercase?
There was a problem hiding this comment.
Yeah they can but it will not give well defined results. I could validate inputs better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
This was way complicated. Thank goodness there was a robust python implementation available.
Changes:
quat_to_euler