Port key and mouse to SDL3 #3207
Open
+87
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
reviewed
Nov 2, 2024
| /* SDL3 changed the mouse API to deal with float coordinates, for now we | ||
| * still truncate the result to int before returning to python side. | ||
| * This can be changed in a breaking release in the future if needed. */ | ||
| float x, y; |
There was a problem hiding this comment.
So it gets it as a float, how does it get converted to an int? Because it gets passed a function that takes ints.
There was a problem hiding this comment.
Yeah that just happens implicitly, I didn't bother documenting it because I didn't think it should cause any confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just following the footsteps of #3206 but separated out in a different PR because these changes are not as trivial as those