Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latest SDL3 and MSYS2 fails #3201

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix latest SDL3 and MSYS2 fails #3201

merged 2 commits into from
Oct 31, 2024

Conversation

ankith26
Copy link
Member

These are actually two independent issues that somehow popped up at the exact same time, hence the common PR fixing both as the fixes are trivial.

@ankith26 ankith26 requested a review from a team as a code owner October 29, 2024 05:53
@yunline yunline added build Compiling stuff sdl3 CI Issue with the Continuous Integration (CI), the actions/bots that test things labels Oct 29, 2024
bilhox
bilhox approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Starbuck5
Starbuck5 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit!

@ankith26 ankith26 added this to the 2.5.3 milestone Oct 31, 2024
@ankith26 ankith26 merged commit c5781dc into main Oct 31, 2024
7 checks passed
@ankith26 ankith26 deleted the ankith26-fix-ci branch October 31, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@bilhox bilhox bilhox approved these changes

Assignees
No one assigned
Labels
build Compiling stuff CI Issue with the Continuous Integration (CI), the actions/bots that test things sdl3
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ankith26 @Starbuck5 @bilhox @yunline