Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better meson error on windows when libraries versions are not correct #3178

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Better meson error on windows when libraries versions are not correct #3178

merged 2 commits into from
Oct 17, 2024

Conversation

bilhox
Copy link
Contributor

@bilhox bilhox commented Oct 16, 2024

Closes #3099 .

All the details are in the title.

@bilhox bilhox requested a review from a team as a code owner October 16, 2024 11:03
@bilhox bilhox added Windows meson Meson build system labels Oct 16, 2024
ankith26
ankith26 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.5.3 milestone Oct 17, 2024
damusss
damusss approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've actually encountered an unclear error that required this fix at least twice, thanks 👍

@damusss damusss merged commit 5af69f9 into pygame-community:main Oct 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@damusss damusss damusss approved these changes

Assignees
No one assigned
Labels
meson Meson build system Windows
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.

Windows - Meson does not check if the version of installed libraries match with the one built with
3 participants
@bilhox @ankith26 @damusss