Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL 2.30.8 #3168

Merged
merged 1 commit into from
Oct 12, 2024
Merged

SDL 2.30.8 #3168

merged 1 commit into from
Oct 12, 2024

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 requested a review from a team as a code owner October 12, 2024 05:32
ankith26
ankith26 approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When the tests pass lets get this in. Thanks! 🎉

@ankith26 ankith26 added this to the 2.5.2 milestone Oct 12, 2024
Matiiss
Matiiss approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this actually compiles
Otherwise LGTM of course

@Matiiss Matiiss merged commit 3ce1d23 into main Oct 12, 2024
27 checks passed
@Matiiss Matiiss deleted the starbuck-SDL-2.30.8 branch October 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@Matiiss Matiiss Matiiss approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @ankith26 @Matiiss