Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: better wasm fencing #3163

Merged
merged 1 commit into from
Oct 13, 2024
Merged

wasm: better wasm fencing #3163

merged 1 commit into from
Oct 13, 2024

Conversation

pmp-p
Copy link
Member

@pmp-p pmp-p commented Oct 10, 2024

No description provided.

@pmp-p pmp-p requested a review from a team as a code owner October 10, 2024 14:29
@pmp-p pmp-p added WebAssembly Code quality/robustness Code quality and resilience to changes labels Oct 10, 2024
damusss
damusss approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM :)

ankith26
ankith26 reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of places in the codebase use __EMSCRIPTEN__ for webasm fencing, what about those usages, should they all be updated to have wasi fencing too?

@pmp-p
Copy link
Member Author

pmp-p commented Oct 12, 2024 •
edited
Loading

Each fence need invididual review wasi and web can be very different, in case of timers it was not clear how to make them work BOTH on wasi and web but it may be possible to run them from pump()

Let's assume defined(__EMSCRIPTEN__) || defined(__wasi__) means there is a way to do both and just __EMSCRIPTEN__ would mean unknown yet.

ankith26
ankith26 approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, LGTM. Thanks! 🥳

@ankith26 ankith26 added this to the 2.5.2 milestone Oct 13, 2024
@ankith26 ankith26 merged commit c5a419b into main Oct 13, 2024
28 checks passed
@ankith26 ankith26 deleted the timer_wasm_fence branch October 13, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@damusss damusss damusss approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes WebAssembly
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pmp-p @ankith26 @damusss