Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage CI created, hopefully it works first time lol #2990

Merged
merged 5 commits into from
Aug 18, 2024
Merged

Coverage CI created, hopefully it works first time lol #2990

merged 5 commits into from
Aug 18, 2024

Conversation

oddbookworm
Copy link
Member

I wanted to see what would happen if we generate coverage in our CI, so let's see what happens lol

@oddbookworm oddbookworm added Code quality/robustness Code quality and resilience to changes tests tests (module) CI Issue with the Continuous Integration (CI), the actions/bots that test things labels Jul 13, 2024
@oddbookworm oddbookworm requested a review from a team as a code owner July 13, 2024 17:59
@oddbookworm oddbookworm force-pushed the coverage-ci branch 2 times, most recently from 8a804b5 to 4fd3b42 Compare July 13, 2024 18:36
@ankith26 ankith26 force-pushed the coverage-ci branch 2 times, most recently from dfe22f2 to 6542294 Compare July 15, 2024 16:43
@ankith26 ankith26 mentioned this pull request Jul 15, 2024
Merged
@ankith26
Copy link
Member

This PR is now passing with the meson buildconfig, I rebased the branch to get the fix from #2996

The PR looks ready to me, though @oddbookworm if you want to experiment more, feel free to. I looked for actions that can integrate with lcov and put things out as a github comment, and I found https://github.com/marketplace/actions/code-coverage-report

@oddbookworm
Copy link
Member Author

That looks super interesting. I’ll look into using that when I get home

@oddbookworm oddbookworm force-pushed the coverage-ci branch 5 times, most recently from 06da6f1 to 11bd8d3 Compare July 19, 2024 21:27
@pygame-community pygame-community deleted a comment from github-actions bot Jul 20, 2024
ankith26
ankith26 approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a review and a question but apart from that this PR LGTM, thanks! 🥮

.github/workflows/build-ubuntu-coverage.yml Outdated Show resolved Hide resolved
.github/workflows/build-ubuntu-coverage.yml Outdated Show resolved Hide resolved
ankith26
ankith26 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👍

@ankith26 ankith26 added this to the 2.5.2 milestone Aug 15, 2024
MyreMylar
MyreMylar approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 3183d16 into main Aug 18, 2024
23 checks passed
@ankith26 ankith26 deleted the coverage-ci branch August 20, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things Code quality/robustness Code quality and resilience to changes tests tests (module)
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@oddbookworm @ankith26 @MyreMylar