Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow this crate to be used in no_std #18

Closed
wants to merge 1 commit into from
Closed

Allow this crate to be used in no_std #18

wants to merge 1 commit into from

Conversation

notgull
Copy link

@notgull notgull commented Oct 29, 2022

Resolves #17 by implementing initial no_std support. This is a breaking change. I did not implement no_alloc because it would require a substantial change to the codebase.

@pyfisch
Copy link
Owner

pyfisch commented Oct 30, 2022

This is a breaking change.

Is this only breaking because of the Cargo features, if you use no-default-features? Or does it actually require code changes?

@notgull
Copy link
Author

notgull commented Oct 30, 2022

Is this only breaking because of the Cargo features, if you use no-default-features? Or does it actually require code changes?

Without the std feature, certain error types no longer implement std::error::Error, which is technically a breaking change.

@pyfisch
Copy link
Owner

pyfisch commented Oct 30, 2022

Postponed until no-std support is needed in a project.

@pyfisch pyfisch closed this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make this crate no_std
2 participants