-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid slashes in datatree coordinate names #9492
Open
TomNicholas
wants to merge
18
commits into
pydata:main
Choose a base branch
from
TomNicholas:datatree_forbid_slashes_in_child_names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Forbid slashes in datatree coordinate names #9492
TomNicholas
wants to merge
18
commits into
pydata:main
from
TomNicholas:datatree_forbid_slashes_in_child_names
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
added
the
topic-DataTree
Related to the implementation of a DataTree class
label
Sep 13, 2024
2 tasks
TomNicholas
changed the title
Forbid slashes in child & coord names
Forbid slashes in datatree coordinate names
Sep 16, 2024
This has now been updated in light of #9494. What this adds is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #9378 (cc @etienneschalk ). This PR also forbids forward slashes in child names, and in coordinate variable names set via
dt.coords.__setitem__
.Not the cleanest PR ever (we raise basically the same error message in 4 different places in the code...) but the point is to prevent inconsistent state now so that we don't release something broken, and then I can make sure to get the obviously-needed refactor mentioned in #9485 (comment) right.
whats-new.rst
api.rst
cc @shoyer