Refine DataTree.equals and DataTree.identical #9473
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.identical()
now checks for inherited coordinates being defined at the same level ("identical on disk"), whereas.equals
now checks only that inherited coordinates are equal, even if defined redundantly ("good enough for xarray's alignment").I've also removed the
from_root
argument fromidentical
andequals
, though we could bring it back if @TomNicholas feels strongly. It felt like a weird thing to check -- if you want to check from the root, why not just directly compare the root objects instead?We should probably also check that
.path
matches, in the case of.identical
only. Currently this is also checked for.equals
, which I would propose we remove.