Allow cubed arrays to be passed to flox groupby #7941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
added
the
topic-chunked-arrays
TomNicholas
changed the title
TomNicholas
commented
Jun 25, 2023
Comment on lines
+25
to
+26
| from collections.abc import Sequence | ||
| from typing import TYPE_CHECKING, Any, Callable |
There was a problem hiding this comment.
This change was supposed to be a separate commit, but this was only because ruff raised an error after regenerating the _aggregations.py file.
TomNicholas
changed the title
dcherian
approved these changes
Jun 26, 2023
dstansby
pushed a commit
to dstansby/xarray
that referenced
this pull request
Jun 28, 2023
* fix error raised by ruff * whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes a small check for chunked arrays in groupby so it now allows cubed arrays through to flox rather than just dask arrays. Does not actually mean that flox groupby will work with cubed yet though, see cubed-dev/cubed#223 and xarray-contrib/flox#224
Tests added(The place to test this would be in [cubed-xarray]whats-new.rstNew functions/methods are listed inapi.rst