Remove dask_array_type checks #7023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
commented
Sep 12, 2022
15 tasks
for more information, see https://pre-commit.ci
…mNicholas/xarray into remove_dask_array_type_checks
TomNicholas
commented
Sep 12, 2022
TomNicholas
commented
Sep 12, 2022
|
Okay I think this is as done as it can be, though we didn't manage to completely remove
|
|
Interesting - did not think that this would work. Potential follow up - make all imports of dask lazy (#6726). |
dcherian
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Great Thanks @TomNicholas
Error: test_xarray_handles_dask
Error: test_dask_defers_to_xarray
Seems like these two should be in the duck array test suite
19 tasks
The extensible public duck array test suite isn't in main yet, so I made a note of it for now #6894 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests addedUser visible changes (including notable bug fixes) are documented inwhats-new.rstNew functions/methods are listed inapi.rst