Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi dimensional histogram (see #5400 instead) #5398

Closed

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented May 28, 2021

Initial work on integrating the multi-dimensional dask-powered histogram functionality from xhistogram into xarray. Just working on the skeleton to fit around the histogram algorithm for now, to be filled in later.

  • Closes Add histogram method #4610
  • API skeleton
  • Redirect plot.hist
  • Tests added
  • Type hinting
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

EDIT: Didn't notice that using git commit --amend has polluted the git history for this branch...

benbovy and others added 2 commits May 28, 2021 15:51
* fastpath cast Xarray's PandasIndex to pd.Index

Also make sure that a multi-index with one unique level are not cast to
a simple pd.Index

* update tests

* [skip-ci] update what's new
@TomNicholas TomNicholas changed the title Multi dimensional histogram Multi dimensional histogram (see #5400 instead) May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add histogram method
2 participants