Test Python 3.13 in CI #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
95e008f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e439e400.logfire-docs.pages.dev |
| Branch Preview URL: | https://3-13-testing.logfire-docs.pages.dev |
Kludex
reviewed
Oct 8, 2024
Comment on lines
+50
to
+51
| 'typing-extensions>=4.1.0; python_version < "3.13"', | ||
| 'typing-extensions>=4.12.2; python_version >= "3.13"', |
There was a problem hiding this comment.
Becase typing-extensions < 4.12.2 doesn't support 3.13
|
It looks like both the core OTEL SDK and instrumentations are still working on 3.13 support: open-telemetry/opentelemetry-python#4211 So let's deprioritize this and wait a bit. When I opened the issue it hadn't occurred to me that dependencies might be this much of a problem. |
|
Sounds good, will close for now and check out some of those other issues you mentioned :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471
Thanks @Kludex for supporting the
rye->uvmigration to prep for this :).Currently blocked by huggingface/tokenizers#1639, I've opened a PR to get this unblocked.