Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remotedb #726

Merged
merged 3 commits into from
Apr 11, 2020
Merged

Remove remotedb #726

merged 3 commits into from
Apr 11, 2020

Conversation

mattwang44
Copy link
Member

[WHY]

  • remotedb is unused
  • firebase-python package is not under-maintained in recent years and has some issue that blocks users from upgrading Python.

[HOW]

  • Remove all the components related to remotedb or firebase-python

@mattwang44 mattwang44 requested a review from yychen April 9, 2020 14:06
tai271828
tai271828 approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@tai271828 tai271828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Thank you for removing the dead code.

@yychen
Copy link
Member

yychen commented Apr 11, 2020

Nice work! Thanks.

@yychen yychen merged commit 2495947 into pycontw:master Apr 11, 2020
gtbcoding pushed a commit to gtbcoding/pycon.tw that referenced this pull request Jul 27, 2020
@yychen
Merge pull request pycontw#726 from mattwang44/remove-remotedb
3019af1 
Remove remotedb
@mattwang44 mattwang44 deleted the remove-remotedb branch January 3, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tai271828 tai271828 tai271828 approved these changes

@yychen yychen Awaiting requested review from yychen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattwang44 @yychen @tai271828