Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sponsors): add sprint-coorganizer level for sponsors api #1205

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

iknowright
Copy link
Contributor

Types of changes

  • New feature

Description

需要增加一個贊助類別為「衝刺開發協辦單位」。

Steps to Test This Pull Request

  1. Go to the path admin site
  2. add a sponsor to see if level 9 exists
  3. Check output, should be as expected as in feat(sponsor): add sprint coorganizer pycontw-frontend#553

Expected behavior

Pasted Graphic 14

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (2a232a0) to head (72439bd).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1205   +/-   ##
=======================================
  Coverage   74.01%   74.02%           
=======================================
  Files          81       81           
  Lines        3060     3061    +1     
=======================================
+ Hits         2265     2266    +1     
  Misses        795      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the typo

src/sponsors/models.py Outdated Show resolved Hide resolved
SPRING_COORGANIZER->SPRINT_COORGANIZER
@iknowright
Copy link
Contributor Author

Hi @SivanYeh @mattwang44

感謝 Sivan 改 typo, 這個應該可以進了?

@SivanYeh SivanYeh merged commit 1b4132f into master Jul 24, 2024
3 checks passed
@SivanYeh SivanYeh deleted the sprint_sponsors branch July 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants