Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade python to 3.10 and remove unused dependencies #1171

Merged
merged 10 commits into from
Apr 13, 2024

Conversation

mattwang44
Copy link
Member

@mattwang44 mattwang44 commented Apr 8, 2024

Types of changes

resolve #1028

Upgrade Python and organize packages

Description

The currently-used Python version (3.6) is already EOL, which also causes GitHub dependabot to stop working on this repo.

  • Major: Upgrade python version to 3.10.14
    • update the version definitions
    • upgrade the packages that are incompatible with python 3.10
  • Minor: remove unused packages

@mattwang44 mattwang44 force-pushed the upgrade-python-310 branch 2 times, most recently from dafa1d3 to 15989f4 Compare April 8, 2024 08:46
Copy link
Collaborator

@josix josix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattwang44
Copy link
Member Author

赫然發現目前用的 Django 3.1 沒有支援 python 3.10,雖然我測試上沒遇到什麼問題,但麻煩請等後續升版 PR 都處理好之後再 deploy 到 staging

@josix
Copy link
Collaborator

josix commented Apr 9, 2024

看起來是因為 2021 年底 django 3.1 EOL 了

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.00%. Comparing base (d680271) to head (e4af425).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
+ Coverage   70.57%   71.00%   +0.42%     
==========================================
  Files          85       85              
  Lines        3392     3445      +53     
==========================================
+ Hits         2394     2446      +52     
- Misses        998      999       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SivanYeh
Copy link
Collaborator

LGTM!

@SivanYeh SivanYeh merged commit 5bac15d into master Apr 13, 2024
3 checks passed
@mattwang44 mattwang44 deleted the upgrade-python-310 branch April 13, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Upgrade Python to >3.6
3 participants