Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JIRA -> Jira branding and use https for links #869

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Update JIRA -> Jira branding and use https for links #869

merged 2 commits into from
Jun 5, 2020

Conversation

josephw
Copy link
Contributor

@josephw josephw commented Nov 14, 2019

I'm so used to the new branding now that 'JIRA' sticks out for me; would you be open to this update?

Apply the branding changes from 2017 and update 'JIRA' to 'Jira'. This should at least be changed in the front-page link, but this goes all in and updates documentation and comments everywhere

Also, update links to use https: URLs.

@josephw
Rebrand JIRA -> Jira.
845564d 
Back in 2017, Atlassian rebranded 'JIRA' to 'Jira':
https://www.atlassian.com/blog/announcements/our-bold-new-brand

Adopt the new version in all commments and descriptions, without any
changes to API. Where it's the API object being talked about, mark up
as ``JIRA`` to clarify.
@josephw
Use https: for URLs.
769afb6 
These links are all now available over TLS. Update to https: URLs.
In most cases this is just adding an 's', but also follow redirections
to pypa.io
@josephw
Copy link
Contributor Author

josephw commented Nov 14, 2019

The build is failing with credential errors; from the message at the top:

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

I'm assuming that a PR from my repo's running without the necessary credentials to pass, so I'm not able to demonstrate a passing build.

@dbaxa dbaxa requested a review from ssbarnea December 5, 2019 00:55
@josephw josephw mentioned this pull request Dec 21, 2019
Closed
@stale
Copy link

stale bot commented Jan 4, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Ticket that is likely to go nowhere and that will be closed soon label Jan 4, 2020
@stale
Copy link

stale bot commented Jan 4, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@josephw
Copy link
Contributor Author

josephw commented Jan 4, 2020

I'm commenting here to ward off the stale bot. Also, @ssbarnea, is there anything I can revise here to help get this merged?

@stale stale bot removed the stale Ticket that is likely to go nowhere and that will be closed soon label Jan 4, 2020
@skwashd
Copy link

skwashd commented Feb 21, 2020

@josephw that is outlined in #896.

@ssbarnea ssbarnea merged commit 7fa3a45 into pycontribs:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaxa dbaxa dbaxa approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephw @skwashd @ssbarnea @dbaxa