Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pytest in verbose mode #5443

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

msimacek
Copy link
Contributor

It would print every individual executed test instead of just dots, which should help with narrowing down aborts and segfaults.

@@ -527,7 +527,7 @@ set(PYBIND11_TEST_PREFIX_COMMAND
CACHE STRING "Put this before pytest, use for checkers and such")

set(PYBIND11_PYTEST_ARGS
""
"-v"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting. I wasn't aware of this option.

This will change the behavior for people working interactively. Maybe it's better to systematically change the commands in .github/workflows/ci.yml instead? That'll only affect the GitHub Actions logs.

@henryiii WDYT?

For Henry:

We saw this error (:snake: graalpy-24.1 • ubuntu-20.04 • x64):

It was "fixed" simply by rerunning:

The logs from the first run don't have enough information for us to guess what might have gone wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@msimacek
Copy link
Contributor Author

Oh, I already hit the transient failure. I'll try to investigate

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msimacek, I'll merge this now, since it's independent of the transient failure.

@rwgk rwgk merged commit 08095d9 into pybind:master Nov 14, 2024
80 of 81 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Possibly needs a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants