chore: use Lychee pre-commit hook

[agriyakhetarpal]

CI time is not a concern for our website, so even if our linter takes thirty seconds instead of five, that should be fine

[netlify]

❌ Deploy Preview for pybamm-developer-preview failed.

Name	Link
🔨 Latest commit	9842478
🔍 Latest deploy log	https://app.netlify.com/sites/pybamm-developer-preview/deploys/6776e89d31b77d0008a48d92

[agriyakhetarpal]

Strange, works fine locally

[arjxn-py]

Thanks @agriyakhetarpal, it also doesn't show that for which specific link it is failing for. Is it something it'll show like previous workflow?

[agriyakhetarpal]

Yes, it would show which link it would fail for, but it doesn't run with https://pre-commit.ci, so the links were not checked with this commit.

[agriyakhetarpal]

https://pre-commit.com/#rust

Looks like this is an issue worth reporting in lycheeverse/lychee upstream: it works with pre-commit locally and would do so with a GHA setup, but it doesn't work with https://pre-commit.ci. I'm not sure if I have the time to prepare a proper report and investigate right now. Would you like to do that, @arjxn-py?

[arjxn-py]

https://pre-commit.com/#rust

Looks like this is an issue worth reporting in lycheeverse/lychee upstream: it works with pre-commit locally and would do so with a GHA setup, but it doesn't work with https://pre-commit.ci. I'm not sure if I have the time to prepare a proper report and investigate right now. Would you like to do that, @arjxn-py?

Sure @agriyakhetarpal, thanks for pinging. Would be happy to do that.