Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to remove shared.py #4401

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

prady0t
Copy link
Contributor

@prady0t prady0t commented Sep 1, 2024

Description

Trying to remove contents of shared.py using pytest fixtures.

Signed-off-by: Pradyot Ranjan <[email protected]>
@prady0t prady0t marked this pull request as draft September 1, 2024 13:10
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (b6fa67a) to head (cc61533).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4401   +/-   ##
========================================
  Coverage    99.46%   99.46%           
========================================
  Files          293      293           
  Lines        22332    22332           
========================================
  Hits         22212    22212           
  Misses         120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratman
Copy link
Contributor

kratman commented Oct 1, 2024

@prady0t What is the status of this one?

@prady0t
Copy link
Contributor Author

prady0t commented Oct 2, 2024

Still working. Will try to push some commits by the end of this week.

@agriyakhetarpal
Copy link
Member

Gentle ping, @prady0t! I feel this can be revisited now?

@prady0t
Copy link
Contributor Author

prady0t commented Nov 15, 2024

Almost forgot. Let me get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants