Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest and Flatten Dictionaries #4377

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Ubham16
Copy link
Contributor

@Ubham16 Ubham16 commented Aug 26, 2024

Description

Functions that Nest and Flatten Dictionaries for the lithium ion parameter sets, which makes it easier to categorise the parameters, and it aligns with BPX structure of sorting it out by these categories.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman
Copy link
Contributor

kratman commented Nov 4, 2024

@Ubham16 Are you still working on this?

@kratman kratman added the needs-reply Needs further information from the author and may be closed if no response is received label Nov 4, 2024
@github-actions github-actions bot removed the needs-reply Needs further information from the author and may be closed if no response is received label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants