-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: branding content #95
base: main
Are you sure you want to change the base?
Conversation
pre-commit.ci autofix |
|
||
pyOpenSci uses [Itim](https://fonts.google.com/specimen/Itim) and [Poppins](https://fonts.google.com/specimen/Poppins?query=poppins) as its fonts. Itim is most commonly used as a header, while Poppins is used for the body of a text. Poppins is available in multiple weights, and at this time pyOpenSci uses the most appropriate weight for accessibility and readability, which varies by use case. Both of these fonts are available via [Google Fonts](https://fonts.google.com/). | ||
|
||
## Diversity, Equity, Inclusion, and Accessibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kierisi Before I review this in its entirety, I'm curious—why is DEIA on a branding page? I could definitely see accessibility fitting in here as a statement that links to DEIA in our organizational values. I think you have some nice content here, but I don't think that the full DEIA statement belongs here. Rather, I'd put it in our org values and make a focused statement here around accessibility as it relates to font and alt tags. I haven't looked at the guidebook as a whole in a while, but I'm curious what your thoughts are on where this belongs in the handbook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lwasser this is where it was listed in the google doc version of the handbook. happy to move it to organizational values if you'd prefer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kierisi i do understand that. That is an old document and things have been moved around a lot. It would be nice for you to consider where content belongs as you work on this as a part of this task. Please answer my question above.
I'm curious what your thoughts are on where this belongs in the handbook.
Do you think it makes sense in that section? If you don't, I'd greatly appreciate your considering the content relevance on this page and suggesting it go somewhere else as a part of the task of creating this handbook section. I do think a note on accessibility makes sense here. Do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it makes sense to me that DEIA language would go into branding, because it is a core component of our brand identity, which is why I didn't make suggestions for it to go elsewhere.
I do think it makes sense to add more context on accessibility as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is reasonable. Please add more details about accessibility and how our brand addresses that
some examples: alt tags, responsive design, colors, fonts etc etc. Link out to other relevant sections as it makes sense - for example alt tags could link to the website section on adding figures that you worked on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in latest commit!
pre-commit.ci autofix |
did a first pass at updating the branding content, including:
I pulled our DEI language from the website and Code of Conduct, so any feedback (on all sections) is welcome!