Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding grain clustering for ACOM #525

Merged
merged 16 commits into from
Oct 6, 2023
Merged

Conversation

cophus
Copy link
Member

@cophus cophus commented Sep 25, 2023

And a bunch of additional options, like min angle spacing between multiple zone axes. Functionality is shown in the attached notebook.

@cophus
Copy link
Member Author

cophus commented Sep 25, 2023

@cophus cophus requested a review from sezelt September 25, 2023 02:16
Copy link
Member

@sezelt sezelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some changes, to add missing documentation in old functions and to switch the progressbar to be tqdm-based. Tested working using the example notebook.

@sezelt
Copy link
Member

sezelt commented Oct 5, 2023

I'm not sure why the readthedocs check is failing, @bsavitzky or @alex-rakowski do you have any ideas? Once that is resolved, this is OK to merge.

@sezelt sezelt merged commit b35d8ec into py4dstem:dev Oct 6, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants