DEV: make make_release.py compatible with windows environment

[pubpub-zz]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (e14b991) to head (bcbf5db).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2894      +/-   ##
==========================================
+ Coverage   96.43%   96.44%   +0.01%     
==========================================
  Files          52       52              
  Lines        8726     8726              
  Branches     1721     1589     -132     
==========================================
+ Hits         8415     8416       +1     
  Misses        182      182              
+ Partials      129      128       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pubpub-zz]

the doc compilation failed randomly. This should be OK

[stefan6419846]

Could you please add a test to cover the parse_commit_line change accordingly?

[pubpub-zz]

I have no client on how to test a program file not within tests folder

[stefan6419846]

There is nothing special about this, see the existing test: https://github.com/py-pdf/pypdf/blob/main/tests/scripts/test_make_release.py

[MartinThoma]

I just gave it a shot - works for me

(except parse_commit_line where I had to replace line 360 by author_login = authors.get(commit_hash, author), but that is not related to the PR)

[pubpub-zz]

I just gave it a shot - works for me

(except parse_commit_line where I had to replace line 360 by author_login = authors.get(commit_hash, author), but that is not related to the PR)

Can you clarify what error did you get and what was the commit_hash value ?

[stefan6419846]

I would still prefer to see a test added here.

(except parse_commit_line where I had to replace line 360 by author_login = authors.get(commit_hash, author), but that is not related to the PR)

Which indicates that an author could not be mapped. In theory, this should not occur, although there might be edge cases. Nevertheless, this should probably be fixed and tested as well.

[pubpub-zz]

I would still prefer to see a test added here.

Agréé. in progress

Which indicates that an author could not be mapped. In theory, this should not occur, although there might be edge cases. Nevertheless, this should probably be fixed and tested as well.

Agree. I had a similar issue this is why I completed the strip() waiting for feedback from @MartinThoma

[MartinThoma]

It was a key-not-found error - the the hash was not in the dictionary. I haven't looked more into it.

[pubpub-zz]

@MartinThoma
I've been able to reproduce the key not found error, running the script from a branch different to main. Can you confirm it was the same for you

[stefan6419846]

I've been able to reproduce the key not found error, running the script from a branch different to main.

This is not surprising as this script is only intended for the default branch. Running on other branches would require different GitHub API requests.

[pubpub-zz]

This is not surprising as this script is only intended for the default branch. Running on other branches would require different GitHub API requests.

I agree this is not the objective of this script. I've added the test based on what I've internally objerved in windows. Ready for review

[stefan6419846]

While the Windows CI breaks because of broken test file downloads, merging is not possible for now. We should probably wait some time before re-running it to avoid rate limit errors.

[pubpub-zz]

I never understood why the files seem to be properly cached in ubuntu but not in windows any ideas?

[stefan6419846]

Windows does not use the cache as it is not configured there.

[pubpub-zz]

Windows does not use the cache as it is not configured there.

shouldn't we set it up ?

[stefan6419846]

At the moment, this helps detecting invalid links which are not available any more. Thus I am not completely sure about this.