Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/ENH: make attachements compatible with kids, and allow list in RF #2197

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

fix include mypy

ab96331
Select commit
Loading
Failed to load commit list.
Draft

BUG/ENH: make attachements compatible with kids, and allow list in RF #2197

fix include mypy
ab96331
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 2, 2023 in 0s

92.53% (-1.93%) compared to 5a2dd75

View this Pull Request on Codecov

92.53% (-1.93%) compared to 5a2dd75

Details

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (5a2dd75) 94.45% compared to head (ab96331) 92.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
- Coverage   94.45%   92.53%   -1.93%     
==========================================
  Files          43       43              
  Lines        7650     7930     +280     
  Branches     1511     1576      +65     
==========================================
+ Hits         7226     7338     +112     
- Misses        262      393     +131     
- Partials      162      199      +37     
Files Coverage Δ
pypdf/_protocols.py 100.00% <ø> (ø)
pypdf/_reader.py 91.53% <100.00%> (-0.17%) ⬇️
pypdf/constants.py 100.00% <100.00%> (ø)
pypdf/generic/__init__.py 100.00% <ø> (ø)
pypdf/generic/_base.py 99.33% <71.42%> (-0.67%) ⬇️
pypdf/_writer.py 86.91% <58.62%> (-1.47%) ⬇️
pypdf/generic/_data_structures.py 80.62% <46.46%> (-11.29%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.