BUG: Added check for field /Info when cloning reader document

[mnmtz]

Added check for optional field /Info in document root when cloning reader document. (Fixes issue #2049)

[stefan6419846]

Could you please add a corresponding test case as well?

[mnmtz]

example_129.pdf

[pubpub-zz]

@mnmtz
What @stefan6419846 means, is can you add a test in test_reader.py:
you should be able to create a new test function which will create a new pdfwriter with the parameter clone_from receiving the bytes from the url you've posted above.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (534c7b4) 94.17% compared to head (94e296d) 94.17%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2055   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          41       41           
  Lines        7332     7333    +1     
  Branches     1441     1442    +1     
=======================================
+ Hits         6905     6906    +1     
  Misses        266      266           
  Partials      161      161           

Files Changed	Coverage Δ
pypdf/_writer.py	87.81% <100.00%> (+0.01%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MartinThoma]

Thank you for your contribution @mnmtz :-) If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

[MartinThoma]

I've labeled this with "BUG", because from the users perspective it fixed something that was wrong. This is mainly relevant for where to put it in the CHANGELOG. I doubt any user would get excited about this change, although it's an important improvement. ENH (enhancements, new features) are typically things that were not supported beforehand and expand the capabilities of pypdf.

There are many edge cases. For example, @pubpub-zz recently improved the image support. There I decided to go with ENH, because it were bigger changes