Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Handle single element ColorSpace list #2026

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

pubpub-zz
Copy link
Collaborator

fixes #2023

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a327df6) 94.07% compared to head (cc051d5) 94.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2026   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files          33       33           
  Lines        7104     7106    +2     
  Branches     1421     1422    +1     
=======================================
+ Hits         6683     6685    +2     
  Misses        263      263           
  Partials      158      158           
Files Changed Coverage Δ
pypdf/filters.py 94.20% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma all yours

@MartinThoma
Copy link
Member

Thank you :-)

What does "singleton" refer to in this context?

@pubpub-zz
Copy link
Collaborator Author

pubpub-zz commented Jul 27, 2023

list of 1 item only, 😉

@MartinThoma MartinThoma changed the title BUG : singleton in ColorSpace BUG: Handle single element ColorSpace list Jul 27, 2023
@MartinThoma MartinThoma merged commit 0a9055d into py-pdf:main Jul 27, 2023
12 checks passed
@MartinThoma
Copy link
Member

Nice! Thank you for the fix and the explanation 🙏 :-)

@pubpub-zz
Copy link
Collaborator Author

image
😤🤣🤣🤣🤣🤣🤣

@MartinThoma
Copy link
Member

I only knew the computer science definition: A design pattern that restricts the instantiation of a class to a single object 😄

MartinThoma added a commit that referenced this pull request Jul 29, 2023
## What's new

### New Features (ENH)
-  Accelerate image list keys generation (#2014)
-  Use `cryptography` for encryption/decryption as a fallback for PyCryptodome (#2000)
-  Extract LaTeX characters (#2016)
-  ASCIIHexDecode.decode now returns bytes instead of str (#1994)

### Bug Fixes (BUG)
-  Add RunLengthDecode filter (#2012)
-  Process /Separation ColorSpace (#2007)
-  Handle single element ColorSpace list (#2026)
-  Process lookup decoded as TextStringObjects (#2008)

### Robustness (ROB)
-  Cope with garbage collector during cloning (#1841)

### Maintenance (MAINT)
-  Cleanup of annotations (#1745)

[Full Changelog](3.13.0...3.14.0)
@pubpub-zz pubpub-zz deleted the singleton_colorspace branch September 2, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colorspace /DeviceRGB not supported
2 participants