Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: ASCIIHexDecode.decode now returns bytes instead of str #1994

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

pubpub-zz
Copy link
Collaborator

closes #1983

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15 🎉

Comparison is base (6df64af) 93.92% compared to head (49363d7) 94.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1994      +/-   ##
==========================================
+ Coverage   93.92%   94.07%   +0.15%     
==========================================
  Files          33       33              
  Lines        7011     7075      +64     
  Branches     1394     1412      +18     
==========================================
+ Hits         6585     6656      +71     
+ Misses        272      262      -10     
- Partials      154      157       +3     
Impacted Files Coverage Δ
pypdf/filters.py 94.15% <100.00%> (+0.66%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
all yours

@MartinThoma MartinThoma added the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Jul 21, 2023
@MartinThoma MartinThoma changed the title BUG : error in hex decode filter BUG: Error in hex decode filter Jul 23, 2023
tests/test_filters.py Outdated Show resolved Hide resolved
Co-authored-by: Martin Thoma <[email protected]>
@MartinThoma MartinThoma added breaking-change A planned breaking change and removed soon PRs that are almost ready to be merged, issues that get solved pretty soon labels Jul 25, 2023
@MartinThoma
Copy link
Member

@pubpub-zz Let's wait a few days for an answer regarding dcmvdbekerom/pypdfplot#48 (comment) . If it's not a breaking change for them, I think it should be fine to merge the PR as it currently is.

@MartinThoma MartinThoma changed the title BUG: Error in hex decode filter BUG: ASCIIHexDecode.decode now returns bytes instead of str Jul 25, 2023
@MartinThoma MartinThoma merged commit 11ee648 into py-pdf:main Jul 25, 2023
12 checks passed
@MartinThoma
Copy link
Member

Nice!

@pubpub-zz Feel free to make the other filters consistent 🎉 :-)

MartinThoma added a commit that referenced this pull request Jul 29, 2023
## What's new

### New Features (ENH)
-  Accelerate image list keys generation (#2014)
-  Use `cryptography` for encryption/decryption as a fallback for PyCryptodome (#2000)
-  Extract LaTeX characters (#2016)
-  ASCIIHexDecode.decode now returns bytes instead of str (#1994)

### Bug Fixes (BUG)
-  Add RunLengthDecode filter (#2012)
-  Process /Separation ColorSpace (#2007)
-  Handle single element ColorSpace list (#2026)
-  Process lookup decoded as TextStringObjects (#2008)

### Robustness (ROB)
-  Cope with garbage collector during cloning (#1841)

### Maintenance (MAINT)
-  Cleanup of annotations (#1745)

[Full Changelog](3.13.0...3.14.0)
@pubpub-zz pubpub-zz deleted the iss1983 branch September 2, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A planned breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'int' object has no attribute 'isspace'
3 participants