Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting compatibility between PyFPDF & fpdf2 #885

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Aug 13, 2023

Originally suggested by @gmischler there: #433 (reply in thread)

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (2b03836) 93.22% compared to head (0148704) 93.22%.
Report is 2 commits behind head on master.

❗ Current head 0148704 differs from pull request most recent head c6d8ac9. Consider uploading reports for the commit c6d8ac9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #885   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files          27       27           
  Lines        7679     7679           
  Branches     1395     1395           
=======================================
  Hits         7159     7159           
  Misses        328      328           
  Partials      192      192           
Files Changed Coverage Δ
fpdf/fpdf.py 92.55% <ø> (ø)
fpdf/html.py 93.13% <ø> (ø)
fpdf/template.py 90.39% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/History.md Outdated Show resolved Hide resolved
@gmischler
Copy link
Collaborator

Looks good to me! 👍

Along similar lines though: Do we have a list anywhere about features that were added to what was present in PyFPDF? Might be interesting to legacy users as well in deciding about a switch.

@Lucas-C Lucas-C force-pushed the compatibility-between-pyfpdf-and-fpdf2 branch from c6d8ac9 to 67a1ca1 Compare August 13, 2023 12:51
@Lucas-C Lucas-C merged commit 7fce5d0 into master Aug 13, 2023
0 of 10 checks passed
@Lucas-C Lucas-C deleted the compatibility-between-pyfpdf-and-fpdf2 branch August 13, 2023 12:52
@Lucas-C
Copy link
Member Author

Lucas-C commented Aug 13, 2023

Thank you for the review!

Along similar lines though: Do we have a list anywhere about features that were added to what was present in PyFPDF? Might be interesting to legacy users as well in deciding about a switch.

We do not have a comparative list of features,
but fpdf2 features are listed in the documentation home page and in the README.md:
https://github.com/py-pdf/fpdf2#features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants