Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements regarding annotations #1303

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Minor improvements regarding annotations #1303

merged 1 commit into from
Nov 15, 2024

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Nov 15, 2024

  • all AnnotationDict properties can now be passed to FPDF.text_annotation(), FPDF.free_text_annotation(), FPDF.add_action(), FPDF.add_text_markup_annotation() & FPDF.ink_annotation(). This includes title, color, border_width...
  • the y-axis coordinates in the /Rect attribute of annotations were inverted

Checklist:

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@Lucas-C Lucas-C force-pushed the annotation-fixups branch 2 times, most recently from 06501a0 to 59ab49e Compare November 15, 2024 13:50
@Lucas-C Lucas-C merged commit 316b6e4 into master Nov 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant