Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the HTML table with null text in span cells that don't show correctly #1294

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

whoisltd
Copy link

@whoisltd whoisltd commented Oct 26, 2024

Fixes #1293

This Pr to fix HTML table with td tag have rowspan, colspan > 1 and text inside is null the pdf output not show table correctly

Checklist:

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

Copy link
Member

@Lucas-C Lucas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's well done, thank you for your contribution 👍

Could you please add a mention of this fix in CHANGELOG.md as part of this PR?

@whoisltd
Copy link
Author

That's well done, thank you for your contribution 👍

Could you please add a mention of this fix in CHANGELOG.md as part of this PR?

yep, I added it to CHANGELOG.md

@Lucas-C Lucas-C merged commit 3fba534 into py-pdf:master Oct 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML table with null text in span cells that don't show correctly
2 participants