Pxls.space CFAuth & Discord Intent Update #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanillaSixtySix
requested changes
Jul 15, 2024
| if data: | ||
| return data | ||
| timeout = aiohttp.ClientTimeout( | ||
| sock_connect=10.0, sock_read=10.0 | ||
| ) # set a timeout of 10 seconds | ||
| async with aiohttp.ClientSession(timeout=timeout, **kwargs) as session: | ||
| try: | ||
| async with session.get(url) as r: | ||
| async with session.get(url, headers=headers if pxls_cfauth else None) as r: |
There was a problem hiding this comment.
I think leaving headers in would be fine, even if the dict is empty.
| import aiohttp | ||
| import numpy as np | ||
| from aiohttp.client_exceptions import ClientConnectionError, InvalidURL | ||
| from typing_extensions import ParamSpec | ||
|
|
||
| from dotenv import load_dotenv # this might be me being lazy but if it works, it works |
There was a problem hiding this comment.
Minor nitpick - this is fine, the comment can be removed.
Comment on lines
+45
to
+53
| if self.pxls_cfauth: | ||
| headers = { | ||
| "Cookie": f"pxls-validate={pxls_validate}", | ||
| "x-pxls-cfauth": f"{self.pxls_cfauth}" | ||
| } | ||
| else: | ||
| headers = { | ||
| "Cookie": f"pxls-validate={pxls_validate}" | ||
| } |
There was a problem hiding this comment.
Instead of assigning headers twice, you should assign it once with Cookie as the default item, then add x-pxls-cfauth if using self.pxls_cfauth.
There was a problem hiding this comment.
I'll take note of this, thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Clueless for the first time with everything in env filled, there are 403 errors everywhere (in pxls.space).
This is because of an API change where if you don't have something called cfauth, it won't let you do anything.
I went ahead and fixed the websocket and the get_content definition by adding a header with the cfauth.
I also updated intents so that it uses only Message Content Intent rather than Intent.all (because that's all it needs) and I updated the env file to add the cfauth.
Update: I made cfauth optional as third-parties don't need such things.