Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support disabling of dojo joining #209

Closed
wants to merge 1 commit into from
Closed

Conversation

zardus
Copy link
Contributor

@zardus zardus commented Sep 2, 2023

This adds a joinable tag to dojos, which allows the disabling of new joins to a dojo.

@ConnorNelson
Copy link
Member

What is the usecase for someone not being able to join a dojo? Official dojos are already not joinable (except as a student for a course dojo), I don't think we even really need to keep requiring community dojos to be joinable, they should just follow the same model as official dojos. Finally there are private dojos, which have a password to gatekeep joining.

@zardus
Copy link
Contributor Author

zardus commented Sep 2, 2023

But it passed CI.....

Honestly, I'd forgotten about passwords. Do we have an example of a password-protected dojo I could play around with?

@adamdoupe
Copy link
Contributor

@zardus CI is only testing that both parts build and that the website comes up. We need to actually add test cases that exercise functionality so you can get the warm fuzzy of CI
#208 (comment)

@ConnorNelson
Copy link
Member

It may have passed Continuous Integration, but it hasn't passed Connor Integration 😉

There aren't any open source private dojos, since that wouldn't make any sense (maybe the password shouldn't be specified in the yml?).

https://github.com/pwncollege/cse365-2023-summer/blob/main/dojo.yml is an example of a dojo with a password. It's just password: MYPASSWORD at the top level. I probably wouldn't modify that dojo though...

For any on lookers, don't worry, there aren't any fun private challenges in that dojo.

@zardus zardus closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants